Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo (gaal); Add graalvm-java17 #47

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Fix typo (gaal); Add graalvm-java17 #47

merged 1 commit into from
Dec 22, 2022

Conversation

JannikArndt
Copy link
Contributor

  • There's a typo in the readme
  • graalvm-java17 is the latest (and LTS) version, and this setting works (it loads graalvm-ce-java17, incidentally)

@hrj
Copy link

hrj commented May 10, 2022

Confirming that graalvm-java17 and 22.1.0 are working fine in my app.

ckipp01
ckipp01 approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the catch @JannikArndt. LGTM!

Apologies for this sitting here so long.

@ckipp01 ckipp01 merged commit 4e6b4a0 into scalameta:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JannikArndt @hrj @ckipp01