Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings for all unformatted files #27

Merged
merged 2 commits into from Mar 14, 2019

Conversation

poslegm
Copy link
Collaborator

@poslegm poslegm commented Mar 13, 2019

Fixes #17

Current behavior is very uncomfortable for me too.

Why was this not done earlier? Can this change harm the user experience in a case that I didn't think of?

Copy link
Member

@tanishiking tanishiking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for this valuable contribution! @poslegm

@@ -153,7 +153,7 @@ object ScalafmtPlugin extends AutoPlugin {
cached[Boolean](cacheDirectory, FilesInfo.lastModified) { modified =>
val changed = modified.filter(_.exists)
if (changed.size > 0) {
log.info(s"Formatting ${changed.size} Scala sources...")
log.info(s"Checking ${changed.size} Scala sources...")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@tanishiking tanishiking merged commit 4e8e2ea into scalameta:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants