RedundantBraces: rewrite val/var/macro, too

scalameta · Dec 30, 2021 · ec29e08 · ec29e08
1 parent bd78d8b
commit ec29e08
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 19 deletions.
diff --git a/scalafmt-core/shared/src/main/scala/org/scalafmt/rewrite/RedundantBraces.scala b/scalafmt-core/shared/src/main/scala/org/scalafmt/rewrite/RedundantBraces.scala
@@ -310,10 +310,16 @@ class RedundantBraces(ftoks: FormatTokens) extends FormatTokensRewrite.Rule {
             case _ => false
           }
         settings.methodBodies &&
-        getSingleStatIfLineSpanOk(b).exists(innerOk(b)) &&
+        checkBlockAsBody(b, d.body) &&
         !isProcedureSyntax(d) &&
         !disqualifiedByUnit
 
+      case d: Defn.Var => d.rhs.exists(checkBlockAsBody(b, _))
+      case d: Defn.Val => checkBlockAsBody(b, d.rhs)
+      case d: Defn.Type => checkBlockAsBody(b, d.body)
+      case d: Defn.Macro => checkBlockAsBody(b, d.body)
+      case d: Defn.GivenAlias => checkBlockAsBody(b, d.body)
+
       case p: Term.Function if isFunctionWithBraces(p) =>
         okToRemoveAroundFunctionBody(b, true)
 
@@ -329,6 +335,11 @@ class RedundantBraces(ftoks: FormatTokens) extends FormatTokensRewrite.Rule {
     }
   }
 
+  private def checkBlockAsBody(b: Term.Block, rhs: Tree)(implicit
+      style: ScalafmtConfig
+  ): Boolean =
+    rhs.eq(b) && getSingleStatIfLineSpanOk(b).exists(innerOk(b))
+
   private def innerOk(b: Term.Block)(s: Stat): Boolean =
     s match {
       case t: Term.NewAnonymous =>

diff --git a/scalafmt-tests/src/test/resources/newlines/source_classic.stat b/scalafmt-tests/src/test/resources/newlines/source_classic.stat
@@ -433,7 +433,7 @@ val attributes = {
  }
 }
 >>>
-val attributes = {
+val attributes =
   for (_ ← 1 to count)
     yield {
       val tag = d.readUnsignedShort()
@@ -447,7 +447,6 @@ val attributes = {
         Some(c(name))
       }
     }
-}
 <<< 2.13.3 val with for/yield, redundant parens
 maxColumn = 80
 rewrite.rules = [RedundantParens]

diff --git a/scalafmt-tests/src/test/resources/newlines/source_fold.stat b/scalafmt-tests/src/test/resources/newlines/source_fold.stat
@@ -395,18 +395,16 @@ val attributes = {
  }
 }
 >>>
-val attributes = {
-  for (_ ← 1 to count) yield {
-    val tag = d.readUnsignedShort()
-    val length = d.readInt()
-    if (debug) println(s"LNB:   tag ${c(tag)} ($length bytes)")
-    if (tag != s) {
-      skip(d, length)
-      None
-    } else {
-      val name = d.readUnsignedShort()
-      Some(c(name))
-    }
+val attributes = for (_ ← 1 to count) yield {
+  val tag = d.readUnsignedShort()
+  val length = d.readInt()
+  if (debug) println(s"LNB:   tag ${c(tag)} ($length bytes)")
+  if (tag != s) {
+    skip(d, length)
+    None
+  } else {
+    val name = d.readUnsignedShort()
+    Some(c(name))
   }
 }
 <<< 2.13.3 val with for/yield, redundant parens

diff --git a/scalafmt-tests/src/test/resources/newlines/source_keep.stat b/scalafmt-tests/src/test/resources/newlines/source_keep.stat
@@ -438,7 +438,7 @@ val attributes = {
  }
 }
 >>>
-val attributes = {
+val attributes =
   for (_ ← 1 to count)
     yield {
       val tag = d.readUnsignedShort()
@@ -452,7 +452,6 @@ val attributes = {
         Some(c(name))
       }
     }
-}
 <<< 2.13.3 val with for/yield, redundant parens
 maxColumn = 80
 rewrite.rules = [RedundantParens]

diff --git a/scalafmt-tests/src/test/resources/newlines/source_unfold.stat b/scalafmt-tests/src/test/resources/newlines/source_unfold.stat
@@ -498,7 +498,7 @@ val attributes = {
  }
 }
 >>>
-val attributes = {
+val attributes =
   for (_ ← 1 to count)
     yield {
       val tag = d.readUnsignedShort()
@@ -513,7 +513,6 @@ val attributes = {
         Some(c(name))
       }
     }
-}
 <<< 2.13.3 val with for/yield, redundant parens
 maxColumn = 80
 rewrite.rules = [RedundantParens]