-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration: spaces inside parentheses ( arg )
#116
Comments
Please also, and from my POV with greater urgency, spaces inside import selectors. Curly braces without whitespace induce claustrophobia. Currently: -import scala.{ Any, Long, Nothing, StringContext, Unit }
-import scala.annotation.unchecked.{ uncheckedVariance => uV }
-import java.{ lang => jl }
-import java.{ util => ju }
-import java.{ io => jio }
-import java.util.{ function => juf }
-import java.nio.{ file => jnf }
+import scala.{Any, Long, Nothing, StringContext, Unit}
+import scala.annotation.unchecked.{uncheckedVariance => uV}
+import java.{lang => jl}
+import java.{util => ju}
+import java.{io => jio}
+import java.util.{function => juf}
+import java.nio.{file => jnf} |
Out of curiosity, is there any well documented Scala style guide that supports adding spaces like this? I know it's supported in scalariform and clang-format but I don't see it in the official Scala, Scala.js, Spark or Twitter style guides. It's straightforward to fix this issue but each new configuration option adds a burden on scalafmt developers and users. I like clang-format's approach for this http://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options cc/ @cvogt |
FWIW it's also a supported as an opt-in in IntelliJ's code style formatting. |
I've added 3 flags for 0.2.2
following clang-format naming convention. |
I changed my mind and decided to only add The other two have not been properly followed up on since I was asked to support them. It's possible to revert f10ee86 in case we later decide to support those styles. |
@olafurpg our internal coding style for a significantly sized code base at @xdotai would require both |
So +1 for bringing --spacesInParentheses back. However you may want to distinguish calls from signatures. |
@olafurpg Just trying scalafmt for a project. Not having |
Original:
Scalafmt:
I would like the input to look like this:
The text was updated successfully, but these errors were encountered: