Avoid empty lines in the beginning and end of blocks

docs/configuration.md

@@ -432,6 +432,39 @@ else {
 }
 ```
 
+### `newlines.avoidEmptyLinesAroundBlock`
+
+```scala mdoc:defaults
+newlines.avoidEmptyLinesAroundBlock
+```
+
+```scala mdoc:scalafmt
+newlines.avoidEmptyLinesAroundBlock = false
+---
+def foo: String = {
+
+  val aux = {
+
+   "bar"
+
+  }
+
+  aux
+
+}
+```
+
+```scala mdoc:scalafmt
+newlines.avoidEmptyLinesAroundBlock = true
+---
+def foo: String = {
+  val aux = {
+   "bar"
+  }
+  aux
+}
+```
+
 ## Rewrite Rules
 
 To enable a rewrite rule, add it to the config like this

scalafmt-core/shared/src/main/scala/org/scalafmt/config/Edition.scala

@@ -0,0 +1,20 @@
+package org.scalafmt.config
+
+import metaconfig.{Conf, ConfDecoder, ConfEncoder, Configured}
+
+sealed abstract class Edition(val order: Int, val name: String)
+
+object Edition {
+  implicit val ordering: Ordering[Edition] = Ordering.by[Edition, Int](_.order)
+
+  implicit val decoder: ConfDecoder[Edition] = ConfDecoder.instance {
+    case Conf.Str("2019-10") => Configured.ok(Edition201910)
+    case _ => Configured.ok(EditionLatest)
+  }
+
+  implicit val encoder: ConfEncoder[Edition] =
+    ConfEncoder.instance(edition => Conf.Str(edition.name))
+}
+
+case object Edition201910 extends Edition(0, "2019-10")
+case object EditionLatest extends Edition(Int.MaxValue, "latest")

scalafmt-core/shared/src/main/scala/org/scalafmt/config/Newlines.scala

@@ -3,6 +3,8 @@ package org.scalafmt.config
 import metaconfig._
 import metaconfig.generic.Surface
 
+import Edition.ordering._
+
 /**
   * @param penalizeSingleSelectMultiArgList
   *   If true, adds a penalty to newlines before a dot starting a select
@@ -110,9 +112,14 @@ case class Newlines(
     beforeImplicitKWInVerticalMultiline: Boolean = false,
     alwaysBeforeElseAfterCurlyIf: Boolean = false,
     alwaysBeforeMultilineDef: Boolean = true,
-    avoidAfterYield: Boolean = true
+    avoidAfterYield: Boolean = true,
+    avoidEmptyLinesAroundBlock: Option[Boolean] = None
 ) {
   val reader: ConfDecoder[Newlines] = generic.deriveDecoder(this).noTypos
+
+  def shouldAvoidEmptyLinesAroundBlock(edition: Edition): Boolean = {
+    avoidEmptyLinesAroundBlock.getOrElse(edition > Edition201910)
+  }
 }
 
 object Newlines {

scalafmt-core/shared/src/main/scala/org/scalafmt/config/ScalafmtConfig.scala

@@ -159,7 +159,8 @@ case class ScalafmtConfig(
     verticalAlignMultilineOperators: Boolean = false,
     onTestFailure: String = "",
     encoding: Codec = "UTF-8",
-    project: ProjectFiles = ProjectFiles()
+    project: ProjectFiles = ProjectFiles(),
+    edition: Edition = EditionLatest
 ) {
   private implicit val runnerReader = runner.reader
   private implicit val projectReader = project.reader

scalafmt-core/shared/src/main/scala/org/scalafmt/internal/Router.scala

@@ -184,6 +184,7 @@ class Router(formatOps: FormatOps) {
             selfAnnotation.nonEmpty
         val nl: Modification =
           if (isSelfAnnotation) newlines2Modification(formatToken)
+          else if (style.newlines.shouldAvoidEmptyLinesAroundBlock(style.edition)) NewlineT()
           else NewlineT(shouldGet2xNewlines(tok, style, owners))
 
         val (startsLambda, lambdaPolicy, lambdaArrow, lambdaIndent) =
@@ -347,6 +348,11 @@ class Router(formatOps: FormatOps) {
           )
         }
 
+      case FormatToken(_, T.RightBrace(), _)
+          if style.newlines.shouldAvoidEmptyLinesAroundBlock(style.edition) && newlines > 1 =>
+        Seq(
+          Split(NoSplit, 0)
+        )
       case FormatToken(_, T.RightBrace(), _) =>
         Seq(
           Split(xmlSpace(rightOwner), 0),

scalafmt-tests/src/test/resources/default/Advanced.stat

@@ -223,7 +223,6 @@ callStatement = js.If(genIsInstanceOf(callTrg, rtClass.tpe), {
         rawApply
     } else {
       val reflBoxClassPatched = {
-
         def isIntOrLongKind(kind: TypeKind) = kind match {
           case _: INT | LONG => true
           case _ => false

scalafmt-tests/src/test/resources/default/Apply.stat

@@ -249,7 +249,6 @@ class ResolutionCopier(x: Int) {
 }
 >>>
 class ResolutionCopier(x: Int) {
-
   def visitClassDeclaration(node: ClassDeclaration): Boolean = {
     val toNode = this._toNode.asInstanceOf[ClassDeclaration];
     javaBooleanAnd(

scalafmt-tests/src/test/resources/default/Class.stat

@@ -62,7 +62,6 @@ class MediaStream() extends EventTarget {
 }
 >>>
 class MediaStream() extends EventTarget {
-
   /**
     */
   val ended: Boolean = js.native

scalafmt-tests/src/test/resources/default/Comment.stat

@@ -10,7 +10,6 @@
   }
 >>>
 {
-
   def cancel(reason: Any): js.Promise[Any] = js.native // comment
 
   /**
@@ -29,7 +28,6 @@ object KeyValue {
 }
 >>>
 object KeyValue {
-
   // ================================
   // 6.3.1 Special Key Values
 
@@ -45,7 +43,6 @@ object KeyValue {
 }
 >>>
 object KeyValue {
-
   // comment
   /** This key value */
   final val Unidentified = "Unidentified"
@@ -74,7 +71,6 @@ object D {
   }
 >>>
 object D {
-
   private val decompressedPrefixes: Seq[(String, String)] =
     compressedPrefixes map { case (a, b) => (b, a) }
 
@@ -94,7 +90,6 @@ object Primes {
 }
 >>>
 object Primes {
-
   // prime sieve; use instead of the test or stream when you know the
   // upper bound of the primes you will need.
   // en.wikipedia.org/wiki/Sieve_of_Eratosthenes

scalafmt-tests/src/test/resources/default/DefDef.stat

@@ -9,7 +9,6 @@ object a {
 }
 >>>
 object a {
-
   /**
     * Returns True is this state will always return better formatting than other.
     */

scalafmt-tests/src/test/resources/default/Fidelity.source

@@ -10,7 +10,6 @@ object ScalaJSGroupID {
 }
 >>>
 object ScalaJSGroupID {
-
   def auto_impl(c: Context { type PrefixType = ScalaJSGroupID })()
       : Expr[CrossGroupArtifactID] = {
     reify {}

scalafmt-tests/src/test/resources/default/Idempotency.stat

@@ -86,7 +86,6 @@ val bindingFuture = Http().bindAndHandleSync({
 >>>
 {
   {
-
     {
       {
         {
@@ -103,7 +102,6 @@ val bindingFuture = Http().bindAndHandleSync({
       }
     }
   }
-
 }
 <<< rendering #339
 {{
@@ -130,7 +128,6 @@ val bindingFuture = Http().bindAndHandleSync({
           RequestRenderingContext(request, hostHeader, sendEntityTrigger)
         }
       }
-
     })
   }
 }
@@ -169,7 +166,6 @@ val bindingFuture = Http().bindAndHandleSync({
                                  })
         new ResponseParsingMerge(rootParser)
       }
-
     })
   }
 }

scalafmt-tests/src/test/resources/newlines/alwaysBeforeTopLevelStatements.stat

@@ -132,7 +132,6 @@ object A {
 }
 >>>
 object A {
-
   /** test */
   def foo(): Int = 0
   // bar

scalafmt-tests/src/test/resources/newlines/avoidEmptyLinesAroundBlock.stat

@@ -0,0 +1,55 @@
+maxColumn = 80
+newlines.avoidEmptyLinesAroundBlock = true
+
+<<< should remove empty lines at the beginning of a def block
+def other: String = {
+
+  "Result"
+}
+>>>
+def other: String = {
+  "Result"
+}
+
+<<< should remove empty lines at the beginning and end of a def block
+def other: String = {
+
+  "Result"
+
+}
+>>>
+def other: String = {
+  "Result"
+}
+
+<<< should remove empty lines at the beginning and end of a val block
+def other: String = {
+
+  val aux = {
+
+    "Result"
+
+  }
+
+  aux
+
+}
+>>>
+def other: String = {
+  val aux = {
+    "Result"
+  }
+
+  aux
+}
+
+<<< should remove empty lines at the end of a block
+def other: String = {
+  "Result"
+
+
+}
+>>>
+def other: String = {
+  "Result"
+}

scalafmt-tests/src/test/resources/rewrite/RedundantBraces-case.stat

@@ -15,14 +15,12 @@ object a {
 }
 >>>
 object a {
-
   val x: Int => String = {
     case 2 =>
       "two"
     case _ =>
       "other"
   }
-
 }
 <<< case clauses with stuff
 object a {
@@ -41,7 +39,6 @@ object a {
 }
 >>>
 object a {
-
   val x: Int => String = {
     case 2 =>
       println("TWO")
@@ -50,7 +47,6 @@ object a {
       // Nice
       "other"
   }
-
 }
 <<< case clauses to unit
 object a {
@@ -66,12 +62,10 @@ object a {
 }
 >>>
 object a {
-
   val x: Int => Unit = {
     case 0 =>
     case 1 =>
     case 2 =>
     case _ => println("?")
   }
-
 }

scalafmt-tests/src/test/resources/rewrite/RedundantBraces-if.stat

@@ -15,15 +15,13 @@ object a {
 }
 >>>
 object a {
-
   def x(i: Int): String =
     if (i == 0)
       "zero"
     else if (i < 0)
       "sub-zero"
     else
       "other"
-
 }
 <<< if-else with stuff
 object a {
@@ -50,7 +48,6 @@ object a {
 }
 >>>
 object a {
-
   def x(i: Int): String =
     if (i == 0)
       /* what */
@@ -88,7 +85,6 @@ object a {
 }
 >>>
 object a {
-
   val x: Int => Unit =
     if (i == 0)
       println("zero")
@@ -98,7 +94,6 @@ object a {
   def y(i: Int) =
     if (i > 0)
       println("yes!")
-
 }
 <<< nested if
 object a {

scalafmt-tests/src/test/resources/rewrite/SortModifiers1.source

@@ -32,7 +32,6 @@ private[test] sealed trait Test {
 }
 
 private[test] final object Tests {
-
   protected[Tests] final case object Test1 extends Test {
     final implicit override lazy val name: String = "foo"
   }
@@ -66,7 +65,6 @@ private[test] sealed trait Test {
 }
 
 private[test] final object Tests {
-
   protected[Tests] final case object Test1 extends Test {
     final implicit override lazy val name: String = "foo"
   }