FormatWriter: insert newline after packages #1069 #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
requested changes
Nov 25, 2019
| nextNonCommentWithCount(toks(i).formatToken) | ||
| isMultiline(actualOwner(nextNonComment).tokens.last, i + distance + 1) | ||
| val formatToken = toks(i).formatToken | ||
| def checkPackage: Option[Boolean] = { |
There was a problem hiding this comment.
We should guard this change against edition = 2019-11
There was a problem hiding this comment.
will add the edition here, and post the diffs from scala-repos later today.
for now, working on #1557, i think the solution is incomplete, but chains are surprisingly difficult.
There was a problem hiding this comment.
Chains are very difficult with the current router design. I spent a LOT of time trying to break on plain a.b without exploding the search state but failed.
kitbellew
force-pushed
the
add-blank-line-after-packages
branch
from
3e30c6f
to
00d40a6
Compare
|
@olafurpg rebased, added edition, as requested. updated description regarding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1069
This commit produces no diffs on
scala-repos.