#1627 [18]: FormatOps: ignore line breaks in infix expressions #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olafurpg @tanishiking @poslegm PTAL. This turned out to be the most complex problem, took me almost 3 weeks. I know @olafurpg tried solving this before and eventually gave up; I tried to track down all previous issues relating to infix handling and take them into account. I think the end result is reasonable albeit not always optimal. |
poslegm
reviewed
Apr 11, 2020
scalafmt-core/shared/src/main/scala/org/scalafmt/internal/SplitTag.scala
Outdated
Show resolved
Hide resolved
kitbellew
force-pushed
the
1855
branch
3 times, most recently
from
c53ce57
to
c21cbf0
Compare
poslegm
approved these changes
Apr 13, 2020
Involves choosing the right RHS for it and handle it similarly to other infix types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
newlines.afterInfixparameter to allow formatting of infix expressions and optionally breaking lines after an infix operation (which appears to be always safe, unlike before it); enable it fornewlines.source=fold,unfold. The behaviour and specific parameters/values will be defined in a separate PR containing the documentation.Helps with #1627.
scala-reposdiffs:unfold: kitbellew/scala-repos@6377998fold: kitbellew/scala-repos@1a055b5unfold: kitbellew/scala-repos@edbae8c