State: fix column positions for multiline strings #2009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, multiline strings are handled inconsistently; computation of state columns also assumes that every line is aligned on the opening quotes, whether or not there is a margin symbol (
|
) and whether various margin-handling flags are set.Instead, try to estimate the length of each line post-formatting and use that in computing the columns.
Fixes #1640.
scala-repos
diffs: