Router: don't add extra indent for fewer braces #3518
Conversation
|
Depends on #3514. |
docs/configuration.md
Outdated
| indent.fewerBraces | ||
| ``` | ||
|
|
||
| > In Scala 3.3.0-RC3, only `never` provides compiler-compatible code. |
There was a problem hiding this comment.
Should we introduce a setting based on something that might be fixed? I would hold off in that case
There was a problem hiding this comment.
could you explain it, please? if this is fixed in the compiler, some people might still prefer different options. and if it's not, then the current implementation doesn't work.
by the way, are you and Martin close to an agreement on that fix? :)
There was a problem hiding this comment.
only never provides compiler-compatible code.
That's what worries me, if user sets something wrong it breaks their compilation, no?
by the way, are you and Martin close to an agreement on that fix? :)
I need to come back to it, don't remember what's the current status :O
There was a problem hiding this comment.
onlyneverprovides compiler-compatible code.That's what worries me, if user sets something wrong it breaks their compilation, no?
so what's the solution, then? right now, it will always break their compilation...
There was a problem hiding this comment.
the only other suggestion i might have is
- add a new dialect field in scalameta to say select can be indented after fewer braces
- set that flag in scala33
- add a new intermediate scala330rc2 dialect where this flag is not set
- move fewer braces to that dialect as well, as it hadn't been available before that.
There was a problem hiding this comment.
so what's the solution, then? right now, it will always break their compilation...
Couldn't we make never the default without the new setting for now?
There was a problem hiding this comment.
so what's the solution, then? right now, it will always break their compilation...
Couldn't we make
neverthe default without the new setting for now?
done
kitbellew
changed the title
And don't indent select after them, as that's not yet supported by the compiler.
And don't indent select after them, as that's not yet supported by the compiler. Fixes #3489.