Fix proposed version syntax #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
requested changes
Jun 6, 2023
| @@ -96,7 +96,7 @@ object Cli { | |||
| "true" == System.getProperty("scalafmt.native-image", "false") | |||
|
|
|||
| private def getProposedConfigVersion(options: CliOptions): String = | |||
| s"version = '$stableVersion'" | |||
| s"version = $stableVersion" | |||
There was a problem hiding this comment.
could you make the same change on line 137 below (where it was copied from)?
There was a problem hiding this comment.
Done, thanks for the heads up 👍
srowen
pushed a commit
to apache/spark
that referenced
this pull request
Jun 30, 2023
…ersion ### What changes were proposed in this pull request? The pr aims to update some maven plugins & scalafmt to newest version, include: - maven-clean-plugin from 3.2.0 to 3.3.1 - maven-shade-plugin from 3.4.1 to 3.5.0 - scalafmt from 3.7.4 to 3.7.5 ### Why are the changes needed? 1.maven-clean-plugin https://github.com/apache/maven-clean-plugin/releases/tag/maven-clean-plugin-3.3.1 2.maven-shade-plugin https://github.com/apache/maven-shade-plugin/releases/tag/maven-shade-plugin-3.5.0 3.scalafmt https://github.com/scalameta/scalafmt/releases/tag/v3.7.5 Router: make sure to indent comments after lambda (scalameta/scalafmt#3556) kitbellew Fix proposed version syntax (scalameta/scalafmt#3555) JD557 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. Closes #41803 from panbingkun/SPARK-44257. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3544, the proposed version string looks something like:
version = '3.7.4'While scalafmt only accepts strings formatted like:
version = 3.7.4Curiously enough, the original issue (#3543) had it right 😅