Merge pull request #1500 from olafurpg/1499

Fix metacp AccessDeniedException on Windows
scalameta · Apr 13, 2018 · 3acc732 · 3acc732
2 parents 0b41ec6 + 2938a04
commit 3acc732
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/semanticdb/metacp/src/main/scala/scala/meta/internal/metacp/Main.scala b/semanticdb/metacp/src/main/scala/scala/meta/internal/metacp/Main.scala
@@ -51,6 +51,14 @@ class Main(settings: Settings, reporter: Reporter) {
             cacheEntry.toNIO,
             StandardCopyOption.REPLACE_EXISTING
           )
+        case _: AccessDeniedException if scala.util.Properties.isWin =>
+          // AccessDeniedException seems to be thrown on Windows when ATOMIC_MOVE is provided
+          // and the target file is being used elsewhere, see https://github.com/scalameta/scalameta/issues/1499
+          Files.move(
+            tmp,
+            cacheEntry.toNIO,
+            StandardCopyOption.REPLACE_EXISTING
+          )
       }
     }
 

diff --git a/tests/jvm/src/test/scala/scala/meta/tests/metacp/BaseMetacpSuite.scala b/tests/jvm/src/test/scala/scala/meta/tests/metacp/BaseMetacpSuite.scala
@@ -12,11 +12,15 @@ abstract class BaseMetacpSuite extends BaseCliSuite {
   val tmp: AbsolutePath = AbsolutePath(Files.createTempDirectory("metacp"))
   tmp.toFile.deleteOnExit()
 
+  def runMetacp(classpath: Classpath): Option[Classpath] = {
+    val settings = Settings().withClasspath(classpath).withCacheDir(tmp).withPar(true)
+    val reporter = Reporter().withOut(System.out).withErr(System.err)
+    Metacp.process(settings, reporter)
+  }
+
   def checkMetacp(name: String, classpath: () => Classpath): Unit = {
     test(name) {
-      val settings = Settings().withClasspath(classpath()).withCacheDir(tmp).withPar(true)
-      val reporter = Reporter().withOut(System.out).withErr(System.err)
-      val result = Metacp.process(settings, reporter)
+      val result = runMetacp(classpath())
       assert(result.nonEmpty)
     }
   }