Preserve parent chain's origin when doing Tree.tranform. (fix #1345) #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasseGuillaume
changed the title
olafurpg
requested changes
Feb 19, 2018
| @@ -88,7 +88,7 @@ class TransformerMacros(val c: Context) extends TransverserMacros { | |||
| var same = true | |||
| ..$transformedFields | |||
| if (same) tree | |||
| else $constructor(..${transformedFields.map(_.name)}) | |||
| else $constructor(..${transformedFields.map(_.name)}).withOrigin(tree.origin) | |||
There was a problem hiding this comment.
Wow, I can't believe it was this simple!
|
|
||
| class ParentSuite extends FunSuite { | ||
|
|
||
| test("Tree.transform does not preserve parent chain origins") { |
There was a problem hiding this comment.
Can we add more detailed tests?
- validate only
Lit.Int(3)is missing pos - validate all other nodes have same position as their corresponding node have before
MasseGuillaume
added a commit
to MasseGuillaume/scalameta
that referenced
this pull request
May 8, 2018
olafurpg
added a commit
that referenced
this pull request
Jul 4, 2018
fikovnik
pushed a commit
to fikovnik/scalameta
that referenced
this pull request
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.