Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude sun._ and com.sun._ from semanticdb-scalac jar #1794

Merged
merged 1 commit into from Oct 19, 2018

Conversation

olafurpg
Copy link
Member

This slims the fatjar from 20mb down to 12mb. I don't know why these
artifacts started being included in the fatjar but I suspect it's caused
by the custom javaHome settings.

Before:

$ du -h semanticdb-scalac.jar
20M

After

$ du -h semanticdb-scalac.jar
12M

This slims the fatjar from 20mb down to 12mb. I don't know why these
artifacts started being included in the fatjar but I suspect it's caused
by the custom javaHome settings.
@olafurpg olafurpg requested a review from xeno-by October 12, 2018 14:07
@olafurpg olafurpg merged commit d64c7ff into scalameta:master Oct 19, 2018
@olafurpg olafurpg deleted the sun branch October 19, 2018 11:44
@olafurpg olafurpg added this to the 4.1.0 milestone Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant