properly forward error/warning count to and from wrapped scalac reporter #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rapped scalac reporter This commit fixes scalameta#1505 and also updates Scala 2.13.1+ implementation to new reporters API introduced in Scala 2.13.1.
ghik
force-pushed
the
reporter-counts
branch
from
f694882
to
8614304
Compare
olafurpg
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #1505 and also updates Scala 2.13.1+ implementation to
new reporters API introduced in Scala 2.13.1.
A simple test would be nice but I'm not sure where to put it (
scala-compileris required on classpath).