Scaladoc: implement parsing of tables #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
force-pushed
the
tables
branch
2 times, most recently
from
989228f
to
0617139
Compare
olafurpg
reviewed
May 31, 2020
scalameta/trees/shared/src/main/scala/scala/meta/internal/Scaladoc.scala
Outdated
Show resolved
Hide resolved
tests/shared/src/test/scala/scala/meta/tests/parsers/ScaladocParserSuite.scala
Outdated
Show resolved
Hide resolved
|
@olafurpg any other modifications you could suggest? otherwise, I'd merge, tag and add to the formatter. |
olafurpg
approved these changes
Jun 3, 2020
| val delimLine = hspaces0 ~ CharsWhileIn("+-") | ||
| val sep = nl ~ (delimLine ~ nl).rep ~ tableSpaceSep | ||
| val table = row.rep(2, sep = sep).map { x => | ||
| val rest = x.tail.map(_.map(_.trim)) |
There was a problem hiding this comment.
Do we know x is always non-empty?
There was a problem hiding this comment.
i will add a test but if i read the .rep(2) above correctly, it should have at least 2 elements.
scalameta/parsers/shared/src/main/scala/scala/meta/internal/parsers/ScaladocParser.scala
Outdated
Show resolved
Hide resolved
kitbellew
commented
Jun 3, 2020
scalameta/parsers/shared/src/main/scala/scala/meta/internal/parsers/ScaladocParser.scala
Outdated
Show resolved
Hide resolved
| val delimLine = hspaces0 ~ CharsWhileIn("+-") | ||
| val sep = nl ~ (delimLine ~ nl).rep ~ tableSpaceSep | ||
| val table = row.rep(2, sep = sep).map { x => | ||
| val rest = x.tail.map(_.map(_.trim)) |
There was a problem hiding this comment.
i will add a test but if i read the .rep(2) above correctly, it should have at least 2 elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.scala-lang.org/blog/2018/10/04/scaladoc-tables.html