Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Extension Group using parameters #2129

Merged

Conversation

kpbochenek
Copy link
Collaborator

@kpbochenek kpbochenek commented Oct 5, 2020

- add mdoc to community tests

  • fix ExtensionGroup with 'using' parameters
  • better handling new for expression control syntax
  • support type '@unchecked'

@kpbochenek kpbochenek force-pushed the extension-group-using-parameter branch 6 times, most recently from 3b4bbb4 to a16833b Compare October 5, 2020 17:42
@kpbochenek kpbochenek force-pushed the extension-group-using-parameter branch from a16833b to 2051ff1 Compare October 5, 2020 19:42
Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpbochenek kpbochenek force-pushed the extension-group-using-parameter branch 2 times, most recently from f590d53 to 92f7cb7 Compare October 6, 2020 09:17
@kpbochenek kpbochenek force-pushed the extension-group-using-parameter branch from 92f7cb7 to 5e5c365 Compare October 6, 2020 10:39
Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea with the annotations!

@kpbochenek kpbochenek merged commit 74cbffa into scalameta:master Oct 6, 2020
@kpbochenek kpbochenek deleted the extension-group-using-parameter branch October 6, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants