Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix newly found Scala 3 parsing issues #2186

Merged
merged 3 commits into from Dec 2, 2020
Merged

Fix newly found Scala 3 parsing issues #2186

merged 3 commits into from Dec 2, 2020

Conversation

tgodzik
Copy link
Collaborator

@tgodzik tgodzik commented Dec 1, 2020

This includes:

  • bump community test commits
  • fix issue with interpolation being on next line with an operator:
val a =
  ""
  + s""
  • make sure poly functions can also exist in TypeApply
  • update Dotty dialect to reflect current status
  • migrate relevant tests from DottySuite

@tgodzik
Make sure Dotty dialect is correct, remove no longer needed separate …
1256554 
…DottySuite, migrate relevant tests to MinorDottySuite, bump community test commits and fix issue with oprator and interpolation on next line.
@tgodzik tgodzik force-pushed the fix-poly-func branch 2 times, most recently from 120d0e7 to 0cdc8c6 Compare December 1, 2020 22:42
kpbochenek
kpbochenek approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@kpbochenek kpbochenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@tgodzik tgodzik merged commit 51a627b into scalameta:master Dec 2, 2020
@tgodzik tgodzik deleted the fix-poly-func branch December 2, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpbochenek kpbochenek kpbochenek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgodzik @kpbochenek