Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Scala Native 0.4.0 #2261

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Add support for Scala Native 0.4.0 #2261

merged 1 commit into from
Mar 3, 2021

Conversation

tgodzik
Copy link
Collaborator

@tgodzik tgodzik commented Mar 3, 2021 •
edited

CC @ekrich

@tgodzik tgodzik mentioned this pull request Mar 3, 2021
Open
5 tasks
@tgodzik tgodzik force-pushed the add-native branch 3 times, most recently from 82678e0 to 498e2c6 Compare March 3, 2021 11:42
@tgodzik tgodzik mentioned this pull request Mar 3, 2021
Closed
@tgodzik tgodzik force-pushed the add-native branch 2 times, most recently from 359d07f to 7ab1165 Compare March 3, 2021 12:03
@tgodzik tgodzik marked this pull request as ready for review March 3, 2021 12:03
WojciechMazur
WojciechMazur approved these changes Mar 3, 2021
View reviewed changes
Copy link

@WojciechMazur WojciechMazur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, linkStubs(false) and gc(immix) in nativeSettings can be ommited since they're using default values, but that just personal preference

@tgodzik
Copy link
Collaborator Author

tgodzik commented Mar 3, 2021 •
edited

Looks good, linkStubs(false) and gc(immix) in nativeSettings can be ommited since they're using default values, but that just personal preference

Removed it then and changed to releaseFast, since it seems that full release is not finishing on scalameta.

olafurpg
olafurpg approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

I'm really excited to compare the performance of Scalafmt with Scala Native vs. native-image 😁

scalameta/trees/shared/src/main/scala/scala/meta/internal/prettyprinters/TreeSyntax.scala
// soft keywords might need to be written with backquotes in some places
/* Soft keywords might need to be written with backquotes in some places.
* Previously used match clause fails due to:
* https://github.com/scala-native/scala-native/issues/2187
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Nice job with finding a minimal repro!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was all @WojciechMazur 🎉

@tgodzik tgodzik merged commit 2db5f93 into scalameta:master Mar 3, 2021
@tgodzik tgodzik deleted the add-native branch March 3, 2021 16:14
@WojciechMazur
Copy link

WojciechMazur commented Mar 3, 2021 •
edited

I'm really excited to compare the performance of Scalafmt with Scala Native vs. native-image

For performance comparison, we need to wait for SN 0.4.1, many performance regressions were fixed there. As an example, databricks/sjsonnet works around 2x faster with the current 0.4.1-SNAPSHOT in comparison to 0.4.0. Also compilation times would be much lower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

@WojciechMazur WojciechMazur WojciechMazur approved these changes

@gabro gabro Awaiting requested review from gabro

@kpbochenek kpbochenek Awaiting requested review from kpbochenek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tgodzik @WojciechMazur @olafurpg