Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow indentation for macro definitions #2728

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

tgodzik
Copy link
Collaborator

@tgodzik tgodzik commented Apr 14, 2022

From what I understand macros must exist as the only statement in a definition, which is way we can't have a block there and indentation should not be tried.

Fixes #2727

@tgodzik tgodzik requested a review from kitbellew April 14, 2022 15:09
Copy link
Contributor

@kitbellew kitbellew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it's not about allowing LF before macro, then?

@tgodzik
Copy link
Collaborator Author

tgodzik commented Apr 14, 2022

so it's not about allowing LF before macro, then?

It's not, I forgot that we remove irrelevant LFs

From what I understand macros must exist as the only statement in a definition, which is way we can't have a block there and indentation should not be tried.

Fixes scalameta#2727
@tgodzik tgodzik merged commit 62e10b7 into scalameta:main Apr 14, 2022
@tgodzik tgodzik deleted the fix-indented-macro branch April 14, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure on previously formatted macro code
2 participants