-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trees: add interleaved param groups to Def/Macro for parameter clause interleaving #2929
Conversation
@Sporarum fyi |
@tgodzik ready to go. |
8bd2a82
to
02b7692
Compare
Looks great! I will take a look a bit later this week, but are we ok releasing a new version before this gets merged just in case? |
if this is likely to be released, but we want to do it in next release, then i'd still like to add an intermediate change in this release. i will send it shortly. |
please take a look: #2987. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this implements faithfully what is in the SIP
(given both the implementation and the tests)
Really nice work, thank you !
scalameta/dialects/shared/src/main/scala/scala/meta/Dialect.scala
Outdated
Show resolved
Hide resolved
1d403c6
to
87e8fa1
Compare
I think we should only merge this one after scala/scala3#14019 is finalized. |
scala/scala3#14019 has been merged ! But it will of course not be usable until the next release of Scala |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lampepfl/dotty#14019 has been merged !
But it will of course not be usable until the next release of Scala
It should be experimental in 3.3.x, right? We can merge it anyway in Scala313
dialect I think, should safe.
meaning, instead of Scala3Future, add the flag to another dialect? |
So instead of replying I edited your answer 😵💫 Sorry about that! :| The answer: |
As soon as 3.3.1 |
Done. Added to 3.3 (which is what scala3 points to), along with fewer braces. |
Also, add
Dialect.allowParamClauseInterleaving
. Based on #2820.