-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trees: use Term.ArgClause, not List[Term] #2942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some smaller comments, otherwise LGTM
extends Term { | ||
@replacedField("4.6.0") final def targs: List[Type] = targClause.values | ||
@replacedField("4.6.0") final def args: List[Term] = argClause.values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we deprecate the old fields so that users know that this changed?
checkFields(tpe.isConstructable) | ||
checkParent(ParentChecks.Init) | ||
@replacedField("4.6.0") final def argss: List[List[Term]] = argClauses.map(_.values).toList |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here with, let's show that users should not use the old methods with @ deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the replacedField annotation macro adds deprecation warning. i can double-check, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen them being deprecated when I checked locally released version 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, of course. fixed in #2960.
Helps with #2869.