Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScannerTokens: leading infix ops start with @ #3055

Merged
merged 2 commits into from
Jan 20, 2023
Merged

ScannerTokens: leading infix ops start with @ #3055

merged 2 commits into from
Jan 20, 2023

Conversation

kitbellew
Copy link
Contributor

Fixes #3051.

@kitbellew
Copy link
Contributor Author

@tgodzik do you know why this check for @ was added in the first place?

tgodzik
tgodzik approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This seems to have been added in https://github.com/scalameta/scalameta/pull/2104/files#diff-f052858eb7b9047c6280a2ec3af411332fd3059b10f3ca5d946df27ca682a973R467 but might not have been needed at all

@kitbellew kitbellew merged commit 6bee190 into scalameta:main Jan 20, 2023
@kitbellew kitbellew deleted the 3051 branch January 20, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metals show error on operators in beginning of the line
2 participants
@kitbellew @tgodzik