SBT: remove geny dependency in testkit #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm... doesn't do what we want |
kitbellew
changed the title
kitbellew
force-pushed
the
480_2
branch
2 times, most recently
from
a5a4aa3
to
2e02401
Compare
geny.Generator was the [shaded] result type of a public method within this library, and since it's primarily used for testing, and because we need no cleanup that Generator is good at, an Iterator is sufficient.
tgodzik
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, geny.Generator is the result type of a public method within this library, and since it's used only for testing, and only in
scalafmtbenchmarks, changing that result type should be ok.