ScalametaParser: parse colon-space arg as lambda #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would simply parse it as a regular expression and then, if we encounter a `=>`, convert it to a `Term.Function`. However, that approach fails when modifiers are used (such as `erased`), so we need to implement a custom parser.
kitbellew
force-pushed
the
sfmt3763_16
branch
from
acfd994
to
fcfacbd
Compare
tgodzik
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would simply parse it as a regular expression and then, if we encounter a
=>, convert it to aTerm.Function.However, that approach fails when modifiers are used (such as
erased), so we need to implement a custom parser.Helps with scalameta/scalafmt#3763.