SBT: fail build on warnings, treat some as info #3561
Conversation
kitbellew
force-pushed
the
3561
branch
5 times, most recently
from
0b744b5
to
ce83f67
Compare
build.sbt
Outdated
| if (isScala213.value) | ||
| List( | ||
| "-Xfatal-warnings", | ||
| "-Wconf:cat=deprecation:is,cat=other-match-analysis:i" |
There was a problem hiding this comment.
@tgodzik @bjaglin perhaps you have some ideas; the match-analysis entry is only for "unreachable code" warnings coming from something in https://github.com/scalameta/scalameta/blob/main/scalameta/common/shared/src/main/scala/scala/meta/internal/transversers/transverser.scala (or the two adjacent implementations, but since both of them show that message, i assumed it was the parent).
since this is a macro, the message doesn't really help in figuring out which actual line of code leads to this. if you have some idea on how to find it, we could fix the problem -- and remove this extra warning exclusion.
There was a problem hiding this comment.
i figured it out: #3562.
Now that most warnings have been fixed, let's make the build stricter. Limit these extra checks to scala-2.13 only, as that's sufficient to ensure clean code and avoids running into tooling differences between versions.
|
now it's all clean, no warnings other than deprecations. ptal. |
|
Thanks @kitbellew ! |
Now that most warnings have been fixed, let's make the build stricter.
Limit these extra checks to scala-2.13 only, as that's sufficient to ensure clean code and avoids running into tooling differences between versions.