Fix invalid pattern: quasiquote handling of Apply #3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new version of scala 2.13 has finally discovered these issues, so let's fix them before adding support for that version. In this particular case, there was an invalid pattern that wouldn't have matched anything as written, but even if we consider the intent of this pattern, it likely came before changes in scalameta parser which re-interpreted a `foo(...$bar)` tree. That is, this code, which would have been parsed originally as `Apply(foo, ArgClause(List(Term.Quasi(rank=2))))`, would now become, through special `Syntactic.TermApply.ArgList`, `Apply(foo, ArgClause.Quasi(rank=1))`. Hence, the `List(...)` would always give way to lower-rank quasi of an `ArgClause`, hence this pattern is no longer necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of scala 2.13 has finally discovered these issues, so let's fix them before adding support for that version.
In this particular case, there was an invalid pattern that wouldn't have matched anything as written, but even if we consider the intent of this pattern, it likely came before changes in scalameta parser which re-interpreted a
foo(...$bar)tree.That is, this code, which would have been parsed originally as
Apply(foo, ArgClause(List(Term.Quasi(rank=2)))), would now become, through specialSyntactic.TermApply.ArgList,Apply(foo, ArgClause.Quasi(rank=1)).Hence, the
List(...)would always give way to lower-rank quasi of anArgClause, hence this pattern is no longer necessary.Fixes #3576.