Lit.{Float,Double}: disallow NaN and Infinity #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitbellew
force-pushed
the
sbt299_11
branch
5 times, most recently
from
7f14018
to
d079536
Compare
These values cannot be specified using the scala numeric literal format and only using predefined constants like `Double.PositiveInfinity` and `Float.NaN`. However, these constants would not be parsed as `Lit.Float` anyway, instead of `Term.Select(...)`.
tgodzik
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values cannot be specified using the scala numeric literal format and only using predefined constants like
Double.PositiveInfinityandFloat.NaN.However, these constants would not be parsed as
Lit.Floatanyway, and instead asTerm.Select(...).