Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-1168 - protobuf names that end with an _ (underscore) #1169

Merged
merged 3 commits into from Jun 2, 2021

Conversation

nikiforo
Copy link
Contributor

@nikiforo nikiforo commented Jun 2, 2021

Just a guess of how #1168 can be fixed

@nikiforo
Copy link
Contributor Author

nikiforo commented Jun 2, 2021

I added issue1168.proto to e2e, run e2eJVM2_13/test and saw the error

/ScalaPB/e2e/target/jvm-2.13/src_managed/main/sample/issue1168/Stacks.scala:42:41: type Stack_* is not a member of package sample.issue1168
[error] did you mean Stack_ or Stacks?
[error]     def addStack(__vs: sample.issue1168.Stack_*): Stacks = addAllStack(__vs)
[error]                                         ^
[error] one error found

Then modified this line, the error dissapeared

@nikiforo nikiforo marked this pull request as ready for review June 2, 2021 17:37
@nikiforo nikiforo changed the title WIP: issue-1168 - protobuf names that end with an _ (underscore) issue-1168 - protobuf names that end with an _ (underscore) Jun 2, 2021
@thesamet
Copy link
Contributor

thesamet commented Jun 2, 2021

Thanks for sending this PR. You probably need to run make_plugin_protos.sh to make the change take effect for generated files that get checked in into this repo.

@nikiforo
Copy link
Contributor Author

nikiforo commented Jun 2, 2021

You probably need to run make_plugin_protos.sh to make the change take effect for generated files that get checked in into this repo.

Thanks, that helped :)

@thesamet thesamet merged commit 2515709 into scalapb:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants