Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pekko-grpc link #1587

Merged
merged 1 commit into from
Oct 5, 2023
Merged

add pekko-grpc link #1587

merged 1 commit into from
Oct 5, 2023

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Oct 5, 2023

Copy link

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but also wait on @pjfanning feedback incase I missed something

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks

@thesamet thesamet merged commit 9089c7a into scalapb:master Oct 5, 2023
15 checks passed
@xuwei-k xuwei-k deleted the pekko-grpc branch October 5, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants