scalapb-runtime-grpc: optimize Marshaller for InProcessTransport #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamet
reviewed
Nov 29, 2023
| * Allows skipping serialization completely when the io.grpc.inprocess.InProcessTransport is used. | ||
| * Inspired by https://github.com/grpc/grpc-java/blob/master/protobuf-lite/src/main/java/io/grpc/protobuf/lite/ProtoInputStream.java | ||
| */ | ||
| class ProtoInputStream[T <: GeneratedMessage](msg: T, val marshaller: Marshaller[T]) extends InputStream { |
There was a problem hiding this comment.
Can you add unit tests for this class?
thesamet
reviewed
Nov 29, 2023
| override def parse(inputStream: InputStream): T = | ||
| companion.parseFrom(inputStream) | ||
| override def parse(inputStream: InputStream): T = inputStream match { | ||
| case pis: ProtoInputStream[T] if pis.marshaller == this => pis.message |
There was a problem hiding this comment.
what's the reason for comparing the marshallers? if not needed, the val marshaller can be removed from the ProtoInputStream class.
There was a problem hiding this comment.
removed in 8d8256c
introduced it to reproduce the following precaution logic, however seems to be redundant indeed.
ittaiz
reviewed
Nov 29, 2023
project/Dependencies.scala
Outdated
| @@ -60,6 +60,7 @@ object Dependencies { | |||
| val grpcNetty = "io.grpc" % "grpc-netty" % versions.grpc | |||
| val grpcServices = "io.grpc" % "grpc-services" % versions.grpc | |||
| val grpcProtocGen = "io.grpc" % "protoc-gen-grpc-java" % versions.grpc | |||
| val grpcInprocess = "io.grpc" % "grpc-inprocess" % versions.grpc | |||
|
LGTM, all tests are passing except formatting. Please run scalafmt within sbt and add to the PR as a new commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1614