Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serializedSize should not return 0 when message has extensions #326

Merged
merged 1 commit into from Aug 26, 2017
Merged

serializedSize should not return 0 when message has extensions #326

merged 1 commit into from Aug 26, 2017

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Aug 25, 2017

fix #320

@xuwei-k xuwei-k mentioned this pull request Aug 25, 2017
Closed
@xuwei-k xuwei-k changed the title serializedSize should't return 0 when message has extensions serializedSize should not return 0 when message has extensions Aug 25, 2017
@thesamet thesamet merged commit 51afced into scalapb:master Aug 26, 2017
@xuwei-k xuwei-k deleted the issue-320 branch August 26, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toByteArray fails for message with only extensions
2 participants
@xuwei-k @thesamet