-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sending metadata #14
Comments
I have squashed PR #20 and made some additional changes that were committed in 52f7fd4:
Please check out the latest snapshot and provide feedback if we can close this issue. Snapshots: https://oss.sonatype.org/content/repositories/snapshots/com/thesamet/scalapb/grpcweb/ |
From my tests, it looks good to me, I have submitted a small PR to update minor details We'll try integrating this internally on a project and get back to you in the next week. Thanks! |
I believe this can be closed. |
I confirm we have been using this successfully for months now. Thanks! |
Right now, the empty metadata is hardcoded, while it could be useful to support sending custom metadata.
On the scala client you can set up an interceptor which can add the metadata before a request is sent, this approach may be feasible on the scalajs client.
One idea to explore is to send cookies and try to setup envoy so that it transforms the cookies in grpc metadata, the drawback is that all request will include the same metadata, while sometimes it's useful to use different metadata per request.
The text was updated successfully, but these errors were encountered: