-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grpc-web with metadata support #20
Conversation
code-gen/src/main/scala/scalapb/grpc_web/GrpcServiceMetadataPrinter.scala
Outdated
Show resolved
Hide resolved
code-gen/src/main/scala/scalapb/grpc_web/GrpcServiceMetadataPrinter.scala
Outdated
Show resolved
Hide resolved
ea83cde
to
1ed77e3
Compare
Can we generate both traits with metadata and without metadata traits (and omit the flag that chooses). This enables users to gradually migrate one interface at a time, rather than all at once. The traits should have two names: |
@thesamet I wonder whether using a default argument could be enough to keep a single interface, so that existing code is not broken and you are free to use the metadata when you need it, while this breaks binary compatibility (from what I understand), I believe we don't need to worry about it this library as it's marked as experimental. |
OK - let's do a default argument. I want to also another change to align with future intentions with scalapb grpc and present state in zio-grpc, the trait should be:
We can have an helper that instantiates a client when |
@thesamet the last suggested change seems to require a bit more work, would you mind if we do that in another PR? we would like to continue on the integration which depends on this PR. |
I think that the additional work is pretty marginal - would be preferred over a quick followup with a breaking change. |
ce69a57
to
bb5c9b9
Compare
Is this ready for review or more changes planned? |
@thesamet it's ready, your requested changes were applied. Thanks. |
Merged via 52f7fd4 |
No description provided.