Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala to 2.12.16 / 2.13.8 / 3.1.3, Scala Native to 0.4.5, and enable Scala 3 Scala Native support #296

Merged
merged 1 commit into from Aug 20, 2022

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Aug 19, 2022

I'd be ok to split in several commits or PRs if needed... (Merging some Scala Steward prior to this one would work too, I'll just rebase.)

@alexarchambault alexarchambault changed the title Update Scala to 2.12.16 / 2.13.8 / 3.1.3 and Scala Native to 0.4.5, and enable Scala 3 Scala Native support Update Scala to 2.12.16 / 2.13.8 / 3.1.3, Scala Native to 0.4.5, and enable Scala 3 Scala Native support Aug 19, 2022
@kiendang
Copy link
Member

kiendang commented Aug 19, 2022

Thanks for this @alexarchambault. I remember trying ScalaPy with a newer version of Scala Native and got error with every version > 0.4.0 when inside virtualenv which is not included in CI here. If I remember correctly it's probably because adding support for virtualenv in #200 requires WString and it interferes with wchar_t* which was added in Scala Native after 0.4.0?

If you have time to check if it works for virtualenv with your local ScalaPy with the bumped dependencies that would be great, but later we probably should add CI for virtualenv here anyway.

I'm currently looking for the fastest way to check this locally because it's a bit convoluted. Will add another comment here when I figure this out.

@kiendang
Copy link
Member

Ok so I think the fastest way to test this is to create a minimal ScalaPy project with Scala Native, create a virtualenv and then run

export SCALAPY_PYTHON_PROGRAMNAME=path/to/your/virtualenv/Python/executable
sbt run

the ScalaPy code inside the project can just be println(py.module("sys").executable) to check if it prints out the correct path to the virtualenv Python executable.

Sorry I'm not with my own computer right now so cannot check this myself. Will take a closer look when I can.

Copy link
Member

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look great! I think we'll wait for @kiendang to take a look at Scala Native + Virtualenv support first though before merging.

@kiendang
Copy link
Member

Just check locally and everything works fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants