Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various commons additions #97

Merged
merged 15 commits into from Feb 16, 2021
Merged

Various commons additions #97

merged 15 commits into from Feb 16, 2021

Conversation

ThomasAngeliniUnibo
Copy link
Contributor

We as @scalaquest/team-1 have inserted Inspect Bag behavior and have move builders' location into the 'commons' package.

@lippo97
Copy link
Contributor

lippo97 commented Feb 15, 2021

We as @scalaquest/team-1 have inserted Inspect Bag behavior

Finally we have this!

@ThomasAngeliniUnibo you are truly cool and good.

@maldins46 maldins46 changed the title Feature/commons additions Various commons additions Feb 15, 2021
@maldins46
Copy link
Contributor

maldins46 commented Feb 15, 2021

Checklist of what we have done/are planning to do in this PR:

  • Customizable messages triggered when the user tries to open an item that is already opened, or locked
  • An item locked with a key should be opened only if the key object is passed explicitly (open the item with the key into the bag is not enough anymore)
  • A command to inspect the content of the bag (as an intransitive ground verb)
  • Re-organization of builder functions (ongoing)
  • FailedToEnter message if the door is locked
  • (to evaluate) Better handling of the inspect the bag behavior, by the use of a sort of global bag object (=> an object always in scope), making this mechanism extendable to other concepts. This is to evaluate, as it is a pretty big change to the model, as if we don't have enough

@maldins46 maldins46 added this to Backlog in ScalaQuest Project via automation Feb 15, 2021
@maldins46 maldins46 moved this from Backlog to In progress (current Sprint) in ScalaQuest Project Feb 15, 2021
@francescogorini
Copy link
Contributor

The image quality isn't like @maldins46's one. However, I think it's too funny 😂

image

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@maldins46 maldins46 merged commit 59c793e into dev Feb 16, 2021
ScalaQuest Project automation moved this from In progress (current Sprint) to Done tasks (current sprint) Feb 16, 2021
@maldins46 maldins46 deleted the feature/commons-additions branch February 16, 2021 15:19
@maldins46 maldins46 moved this from Done tasks (current sprint) to Done tasks (post Sprint) in ScalaQuest Project Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
ScalaQuest Project
Done tasks (post Sprint)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants