Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamoAdmin.namespaceExists()check only prefixes of namespaces #784

Closed
laysakura opened this issue Jan 6, 2023 · 0 comments · Fixed by #782
Closed

DynamoAdmin.namespaceExists()check only prefixes of namespaces #784

laysakura opened this issue Jan 6, 2023 · 0 comments · Fixed by #782
Assignees
@laysakura

Comments

@laysakura
Copy link
Contributor

Describe the bug

DynamoAdmin.namespaceExists()check only prefixes of namespaces.

scalardb/core/src/main/java/com/scalar/db/storage/dynamo/DynamoAdmin.java

Lines 1145 to 1146 in 4f6113f

if (tableName.startsWith(namespace.prefixed())) {
namespaceExists = true;

To Reproduce

Test code: https://github.com/scalar-labs/scalardb/pull/782/files#diff-deac59405708060a7ae11c7066ae51495705cbab43b7c17d94777a8bf30923d6R203-R220

Expected behavior

The test above passes (but fails at 2nd assertion).

Screenshots

Environment (please complete the following information):

  • OS: macOS
  • Java Version: 1.8
  • Scalar DB Version: master

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laysakura laysakura

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: DynamoAdmin.namespaceExists to check full namespace (not prefix) scalar-labs/scalardb
1 participant
@laysakura