Fix ScanBuilder bug #1045
Merged
Fix ScanBuilder bug #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brfrn169
commented
Aug 30, 2023
Comment on lines
+547
to
+550
| this.limit = buildable.limit; | ||
| this.projections.addAll(buildable.projections); | ||
| this.orderings.addAll(buildable.orderings); | ||
| this.consistency = buildable.consistency; |
There was a problem hiding this comment.
We should also pass these parameters here.
Comment on lines
+607
to
+610
| .projections(Arrays.asList("pk1", "ck1")) | ||
| .projection("ck2") | ||
| .projections("ck3", "ck4") | ||
| .where(ConditionBuilder.column("ck1").isGreaterThanInt(10)) |
There was a problem hiding this comment.
We call projection() and projections() before calling where() here, and we lost the values with the bug.
Comment on lines
+628
to
+629
| .limit(10) | ||
| .where(ConditionBuilder.column("ck1").isGreaterThanInt(10)) |
There was a problem hiding this comment.
We call limit() before calling where() here, and we lost the value with the bug.
Comment on lines
+649
to
+652
| .ordering(ordering1) | ||
| .orderings(Arrays.asList(ordering2, ordering3)) | ||
| .orderings(ordering4, ordering5) | ||
| .where(ConditionBuilder.column("ck1").isGreaterThanInt(10)) |
There was a problem hiding this comment.
We call ordering()/orderings() before calling where() here, and we lost the values with the bug.
Comment on lines
+670
to
+671
| .consistency(Consistency.EVENTUAL) | ||
| .where(ConditionBuilder.column("ck1").isGreaterThanInt(10)) |
There was a problem hiding this comment.
We call consistency() before calling where() here, and we lost the value with the bug.
jnmt
approved these changes
Aug 30, 2023
feeblefakie
pushed a commit
that referenced
this pull request
Sep 4, 2023
brfrn169
added a commit
that referenced
this pull request
Oct 26, 2023
brfrn169
added a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a bug where ScanBuilder doesn't create a proper
ScanAllinstance when we callprojection()/projections()/ordering()/orderings()/limit()/consistency()before callingwhere(). I'll add inline comments for the details. Please take a look!