Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor integration tests for Consensus Commit #1346

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

brfrn169
Copy link
Collaborator

@brfrn169 brfrn169 commented Dec 5, 2023

Description

This PR refactors integration tests for Consensus Commit.

Related issues and/or PRs

N/A

Changes made

  • Extracted common logics
  • Separated the integration tests for the include metadata feature

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@brfrn169 brfrn169 self-assigned this Dec 5, 2023
@brfrn169 brfrn169 force-pushed the refactor-integration-test-for-consensus-commit branch 13 times, most recently from 3a52281 to 0985790 Compare December 6, 2023 07:42
@@ -0,0 +1,227 @@
package com.scalar.db.transaction.consensuscommit;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separated the integration tests for the include metadata feature.

@@ -0,0 +1,217 @@
package com.scalar.db.transaction.consensuscommit;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto. Separated the integration tests for include metadata feature.

@@ -0,0 +1,15 @@
package com.scalar.db.transaction.consensuscommit;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted common logics into ConsensusCommitIntegrationTestUtil.

@brfrn169 brfrn169 force-pushed the refactor-integration-test-for-consensus-commit branch from 0985790 to 48d6e6c Compare December 6, 2023 07:52
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
(I've looked over the change, but not throughly 😅 )

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 2162b59 into master Dec 7, 2023
23 checks passed
@feeblefakie feeblefakie deleted the refactor-integration-test-for-consensus-commit branch December 7, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants