-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor integration tests for Consensus Commit #1346
Refactor integration tests for Consensus Commit #1346
Conversation
3a52281
to
0985790
Compare
@@ -0,0 +1,227 @@ | |||
package com.scalar.db.transaction.consensuscommit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separated the integration tests for the include metadata feature.
@@ -0,0 +1,217 @@ | |||
package com.scalar.db.transaction.consensuscommit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto. Separated the integration tests for include metadata feature.
@@ -0,0 +1,15 @@ | |||
package com.scalar.db.transaction.consensuscommit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted common logics into ConsensusCommitIntegrationTestUtil
.
0985790
to
48d6e6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
(I've looked over the change, but not throughly 😅 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
This PR refactors integration tests for Consensus Commit.
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
N/A