-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NullPointerException in EXTRA_READ validation #1624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for fixing this. Sorry for keeping it on hold. I no longer have to hurry for my experiments, but let's discuss how we handle it in a better way when we get a chance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
This PR fixes a bug in the
EXTRA_READ
validation. In this bug,NullPointerException
occurs during theEXTRA_READ
validation when scanning records in a transaction, but some of them are deleted by other transactions.Related issues and/or PRs
N/A
Changes made
Optional.of()
toOptional.ofNullable()
inSnapshot.toSerializableWithExtraRead()
to avoidNullPointerException
Checklist
Additional notes (optional)
N/A
Release notes
Fixed a bug where
NullPointerException
occurs during theEXTRA_READ
validation when scanning records in a transaction, but some of them are deleted by other transactions.