Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported Java version in getting started #840

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

kota2and3kan
Copy link
Contributor

This PR updates the description of the supported Java version in the getting started guide.

In the previous getting started guide, we built ScalarDB itself in that steps. So, we must use Java 8 to build ScalarDB.
However, in the current getting started guide, we can use Java 8 or higher since it gets pre-compiled ScalarDB from the Maven repository.

And, I think there is a possibility that the current description may mislead users that ScalarDB only supports Java 8.
(Actually, I got a such question from a user.)
So, I think it is better to describe Java 8 or higher in the getting started guide.

Also, Gradle 7.1 doesn't support Java 17 or higher.
So, I updated the Gradle version of the getting started project to 7.6 (current latest version).
https://docs.gradle.org/current/userguide/compatibility.html

Please take a look!

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie
Copy link
Contributor

@kota2and3kan Sorry, can you fix the conflict?

@kota2and3kan
Copy link
Contributor Author

@feeblefakie
Thank you for your review!
I will fix the conflict. And after that, I will merge this PR.

@kota2and3kan kota2and3kan merged commit 44a7baf into master Apr 19, 2023
12 checks passed
@brfrn169 brfrn169 added this to Done in 3.9.0 Apr 27, 2023
@brfrn169 brfrn169 deleted the update-supported-java-version branch May 2, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
3.9.0
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants