Change version in add-scalardb-to-your-build.md from 3.8.0 to 3.9.0
#893
Conversation
docs/add-scalardb-to-your-build.md
Outdated
| @@ -6,7 +6,7 @@ You can install it in your application using your build tool such as Gradle and | |||
| To add a dependency on ScalarDB using Gradle, use the following: | |||
| ```gradle | |||
| dependencies { | |||
| implementation 'com.scalar-labs:scalardb:3.8.0' | |||
| implementation 'com.scalar-labs:scalardb:3.9.1-SNAPSHOT' | |||
There was a problem hiding this comment.
This snapshot version doesn't seem to be published. 3.9.0 is better?
> Task :compileJava FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':compileJava'.
> Could not resolve all files for configuration ':compileClasspath'.
> Could not find com.scalar-labs:scalardb:3.9.1-SNAPSHOT.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/com/scalar-labs/scalardb/3.9.1-SNAPSHOT/maven-metadata.xml
- https://repo.maven.apache.org/maven2/com/scalar-labs/scalardb/3.9.1-SNAPSHOT/scalardb-3.9.1-SNAPSHOT.pom
Required by:
project :
There was a problem hiding this comment.
Good point. To use SNAPSHOT versions, we need to add the following snapshot maven repository to build.gradle:
maven {
url 'https://oss.sonatype.org/content/repositories/snapshots/'
}There was a problem hiding this comment.
Should we mention 3.9.0 instead? If so, I think we should update the README.md as well since it mentions using 3.9.1-SNAPSHOT.
There was a problem hiding this comment.
@josh-wong This page is used in the Doc site, right? If so, we should show the released version 3.9.0 instead of the SNAPSHOT version 3.9.1-SNAPSHOT.
And, yes, we should update README as well.
There was a problem hiding this comment.
Thanks for confirming! I've updated both docs (including the README) to mention 3.9.0. PTAL!
There was a problem hiding this comment.
@josh-wong Thank you!
Can you please also update the following files:
- docs/index.md
- docs/getting-started/build.gradle
Thanks.
There was a problem hiding this comment.
@brfrn169 Done!
Should we update https://github.com/scalar-labs/scalardb/blob/docs/3.9/fix-version/build.gradle as well to 3.9.0? Or should that stay as is?
There was a problem hiding this comment.
@josh-wong Thank you!
We don't need to update https://github.com/scalar-labs/scalardb/blob/docs/3.9/fix-version/build.gradle. Thanks.
There was a problem hiding this comment.
@brfrn169 Got it. Thank you for confirming!
josh-wong
changed the title
add-scalardb-to-your-build.md from 3.8.0 to 3.9.1-SNAPSHOTadd-scalardb-to-your-build.md from 3.8.0 to 3.9.0
There was a problem hiding this comment.
LGTM! Thank you!
@josh-wong I will take care of applying the same changes to the master branch and the other release branches. Thanks.
This PR changes the version of ScalarDB mentioned in the
docs/add-scalardb-to-your-build.mddoc (3.8.0) to match the version that is mentioned in the repository'sREADME.md(3.9.1-SNAPSHOT).I think we might need to update
docs/add-scalardb-to-your-build.mdandREADME.mdin themasterbranch as well. If the changes in this PR look OK, I will submit a similar PR for themasterbranch.