Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relational scan for JDBC transactions #925

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Add relational scan for JDBC transactions #925

merged 2 commits into from
Jul 3, 2023

Conversation

jnmt
Copy link
Contributor

@jnmt jnmt commented Jun 30, 2023

This PR adds relational scan processing for JDBC transactions. PTAL!

@jnmt jnmt self-assigned this Jun 30, 2023
@jnmt jnmt added the enhancement New feature or request label Jun 30, 2023
feeblefakie
feeblefakie approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

brfrn169
brfrn169 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

komamitsu
komamitsu approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jnmt jnmt merged commit b94fe75 into master Jul 3, 2023
13 checks passed
@jnmt jnmt deleted the add-relational-scan-for-jdbc-native-transaction branch July 3, 2023 07:19
brfrn169 pushed a commit that referenced this pull request Jul 7, 2023
@jnmt @brfrn169
Add relational scan for JDBC transactions (#925)
70f816a
@brfrn169 brfrn169 mentioned this pull request Nov 28, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komamitsu komamitsu komamitsu approved these changes

@brfrn169 brfrn169 brfrn169 approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

@Torch3333 Torch3333 Awaiting requested review from Torch3333

Assignees

@jnmt jnmt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jnmt @komamitsu @brfrn169 @feeblefakie