Fix utility method to check transactional table metadata #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng if the after column is present
Torch3333
force-pushed
the
fix_util_method_to_test_if_it_is_transaction_table_metadata
branch
from
5ff3842
to
159fc45
Compare
Torch3333
commented
Jul 18, 2023
Comment on lines
+120
to
+123
| && !(nonPrimaryKeyColumn.startsWith(Attribute.BEFORE_PREFIX) | ||
| && tableMetadata | ||
| .getColumnNames() | ||
| .contains(nonPrimaryKeyColumn.substring(Attribute.BEFORE_PREFIX.length())))) { |
There was a problem hiding this comment.
nonPrimaryKeyColumn.startsWith(Attribute.BEFORE_PREFIX)
&& tableMetadata
.getColumnNames()
.contains(nonPrimaryKeyColumn.substring(Attribute.BEFORE_PREFIX.length())
were meant to be written inside parentheses since it first verifies that nonPrimaryKeyColumn starts with Attribute.BEFORE_PREFIX before it creates the substring nonPrimaryKeyColumn.substring(Attribute.BEFORE_PREFIX.length())
To gives more context, if nonPrimaryKeyColumn is not an after image column (verified by line 119), then the clause (line 120 to 123) verifies that nonPrimaryKeyColumn must be a before image column to be a transactional table metadata
Torch3333
changed the title
brfrn169
approved these changes
Jul 18, 2023
feeblefakie
deleted the
fix_util_method_to_test_if_it_is_transaction_table_metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
ConsensusCommitUtils.isTransactionTableMetadata(metadata)is a utility method that returns true if the given table metadata is transactional.Changes
This method is not working correctly when it verifies that the after column is present for a given before column. This PR fixes this wrong behavior.