Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1405): decode uri component for hash values #1407

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

amritk
Copy link
Member

@amritk amritk commented Apr 9, 2024

fixes #1405
Sometimes URL's get encoded, this will ensure selecting the correct endpoint works even if it gets encoded.

@amritk amritk requested a review from marclave as a code owner April 9, 2024 18:11
Copy link

changeset-bot bot commented Apr 9, 2024

🦋 Changeset detected

Latest commit: 49afdab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@scalar/api-reference Patch
@scalar/api-reference-react Patch
@scalar/cli Patch
@scalar/express-api-reference Patch
@scalar/hono-api-reference Patch
@scalar/mock-server Patch
@scalar/nestjs-api-reference Patch
@scalar/nextjs-api-reference Patch
@scalar/docusaurus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Copy link

relativeci bot commented Apr 9, 2024

Job #932: Bundle Size — 1.92MiB (~-0.01%).

49afdab(current) vs 1c021a4 main#930(baseline)

Warning

Bundle contains 4 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
Job #932
     Baseline
Job #930
Improvement  Initial JS 1.92MiB(~-0.01%) 1.92MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 100% 0%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 1041 1041
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 158 158
No change  Duplicate Packages 4 4
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #932
     Baseline
Job #930
Improvement  JS 1.92MiB (~-0.01%) 1.92MiB

View job #932 reportView amrit/fix-1405-encoded-hash branch activityView project dashboard

Copy link
Member

@marclave marclave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome fix @amritk :)

@marclave marclave merged commit f2c2ce8 into main Apr 9, 2024
9 checks passed
@marclave marclave deleted the amrit/fix-1405-encoded-hash branch April 9, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support URL encoded params
2 participants