Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content modal history style #1415

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

antlio
Copy link
Contributor

@antlio antlio commented Apr 10, 2024

Problem
in darkmode when a user open the request history modal, the header displays a background. according to #177 i believe this shouldn't be the case. hope i read you right @cameronrohani :).

before

Solution
use inherit background in modal header for darkmode.

after

@antlio antlio requested a review from marclave as a code owner April 10, 2024 15:29
Copy link

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: 2f4f065

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@scalar/use-modal Patch
@scalar/api-client Patch
@scalar/api-reference Patch
@scalar/api-client-react Patch
@scalar/api-reference-react Patch
@scalar/cli Patch
@scalar/express-api-reference Patch
@scalar/hono-api-reference Patch
@scalar/mock-server Patch
@scalar/nestjs-api-reference Patch
@scalar/nextjs-api-reference Patch
@scalar/docusaurus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@marclave marclave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome fix @antlio

@marclave marclave merged commit e6d1b81 into scalar:main Apr 10, 2024
7 checks passed
@antlio antlio deleted the fix-modal-content-history branch April 11, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants