Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: switch to inter variable #1576

Merged
merged 1 commit into from
May 2, 2024
Merged

refactor: switch to inter variable #1576

merged 1 commit into from
May 2, 2024

Conversation

hwkr
Copy link
Contributor

@hwkr hwkr commented May 1, 2024 •
edited

Add support for variable width inter font. Fixes DOC-1755

@tmastrom these woff2 files need to be uploaded to the CDN: inter-variable.zip

Behold, variableness

Google.Chrome-2024-05-01-12-33-56.mp4

@hwkr hwkr requested a review from tmastrom May 1, 2024 19:36
@hwkr hwkr requested a review from marclave as a code owner May 1, 2024 19:36
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 1, 2024

⚠️ No Changeset found

Latest commit: 378243c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hwkr hwkr mentioned this pull request May 1, 2024
Merged
tmastrom
tmastrom approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@tmastrom tmastrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I'll update the files on the CDN

@geoffgscott geoffgscott merged commit 702c412 into tom/host-fonts-on-cdn May 2, 2024
3 checks passed
@geoffgscott geoffgscott deleted the brynn/variable-inter-font branch May 2, 2024 16:32
hanspagel pushed a commit that referenced this pull request May 6, 2024
@hwkr @hanspagel
refactor: switch to inter variable (#1576)
9110299
tmastrom pushed a commit that referenced this pull request May 6, 2024
@hwkr @tmastrom
refactor: switch to inter variable (#1576)
4caa254
tmastrom pushed a commit that referenced this pull request May 6, 2024
@hwkr @tmastrom
refactor: switch to inter variable (#1576)
a319f75
hanspagel pushed a commit that referenced this pull request May 8, 2024
@hwkr @hanspagel
refactor: switch to inter variable (#1576)
8daa8b1
tmastrom pushed a commit that referenced this pull request May 16, 2024
@hwkr @tmastrom
refactor: switch to inter variable (#1576)
82d1beb
marclave pushed a commit that referenced this pull request May 16, 2024
@hwkr @marclave
refactor: switch to inter variable (#1576)
60da473
tmastrom pushed a commit that referenced this pull request May 22, 2024
@hwkr @tmastrom
refactor: switch to inter variable (#1576)
6c1c475
tmastrom pushed a commit that referenced this pull request May 22, 2024
@hwkr @tmastrom
refactor: switch to inter variable (#1576)
3b8f8ea
tmastrom pushed a commit that referenced this pull request May 29, 2024
@hwkr @tmastrom
refactor: switch to inter variable (#1576)
22a9b2b
marclave added a commit that referenced this pull request May 31, 2024
@tmastrom @hanspagel
@marclave @hwkr
feat: self host api-reference fonts on scalar CDN (#1520)
db7864a 
* chore: self host api-reference fonts on scalar CDN

* chore: update cdn url

* chore: serve fonts as css

* chore: host woff2 fonts on scalar cdn

* refactor: move font css files to a dedicated folder

* docs(changeset): feat: self host fonts on scalar cdn

* refactor: switch to inter variable (#1576)

* chore: use new fonts.scalar cdn url

* docs: update note on fonts

* docs: use custom fonts

---------

Co-authored-by: Hans Pagel <mail@hanspagel.com>
Co-authored-by: marclave <marc@scalar.com>
Co-authored-by: Brynn <brynn@hawker.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmastrom tmastrom tmastrom approved these changes

@marclave marclave Awaiting requested review from marclave

@cameronrohani cameronrohani Awaiting requested review from cameronrohani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hwkr @tmastrom @geoffgscott