Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api client address bar url #1701

Merged
merged 2 commits into from May 11, 2024
Merged

Conversation

antlio
Copy link
Contributor

@antlio antlio commented May 11, 2024

Problem
as highlighted by @Amorim33 and in #1687, breaking layout when url is too long.

Solution
this pr fixes #1687 by allowing scrolling and adding fade to long url.

image

Copy link

changeset-bot bot commented May 11, 2024

🦋 Changeset detected

Latest commit: c30f057

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@scalar/api-client Patch
@scalar/api-client-react Patch
@scalar/api-reference Patch
@scalar/play-button Patch
@scalar/api-reference-react Patch
@scalar/cli Patch
@scalar/express-api-reference Patch
@scalar/fastify-api-reference Patch
@scalar/hono-api-reference Patch
@scalar/nestjs-api-reference Patch
@scalar/nextjs-api-reference Patch
@scalar/nuxt Patch
@scalar/docusaurus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@antlio antlio force-pushed the fix-api-client-address-bar-url branch from bc1415b to f499c78 Compare May 11, 2024 06:42
Copy link

relativeci bot commented May 11, 2024

#1488 Bundle Size — 1.79MiB (+0.01%).

c30f057(current) vs 3748dc5 main#1484(baseline)

Warning

Bundle contains 4 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#1488
     Baseline
#1484
Regression  Initial JS 1.79MiB(+0.01%) 1.79MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 100% 100%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 1073 1073
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 160 160
No change  Duplicate Packages 4 4
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#1488
     Baseline
#1484
Regression  JS 1.79MiB (+0.01%) 1.79MiB

Bundle analysis reportBranch fix-api-client-address-bar-urlProject dashboard

@antlio antlio force-pushed the fix-api-client-address-bar-url branch from f499c78 to c30f057 Compare May 11, 2024 06:58
Copy link
Contributor

Copy link
Member

@marclave marclave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah @antlio nice fix 😎 i saw this happen on the sentry docs friday and forgot to make an issue but seems like @Amorim33 was on it too 💯

@marclave marclave merged commit f871c28 into main May 11, 2024
10 checks passed
@marclave marclave deleted the fix-api-client-address-bar-url branch May 11, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API client layout is breaking when the URL is too long
2 participants