feat: use new proxy 🥳 fix #1396 #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marclave
requested review from
hanspagel,
amritk,
cameronrohani,
hwkr,
antlio,
tmastrom and
geoffgscott
🦋 Changeset detectedLatest commit: 3ec01d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marclave
commented
May 12, 2024
marclave
commented
May 12, 2024
This comment was marked as resolved.
This comment was marked as resolved.
marclave
force-pushed
the
marc/migrate-to-new-proxy
branch
from
21baaa4
to
3d14216
Compare
#1643 Bundle Size — 1.91MiB (+0.05%).Warning Bundle contains 4 duplicate packages – View duplicate packages Bundle metrics
|
| Current #1643 |
Baseline #1642 |
|
|---|---|---|
 Initial JS |
1.91MiB(+0.05%) |
1.91MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
100% |
0% |
| Chunks |
1 |
1 |
| Assets |
1 |
1 |
| Modules |
1082 |
1082 |
| Duplicate Modules |
0 |
0 |
| Duplicate Code |
0% |
0% |
| Packages |
157 |
157 |
| Duplicate Packages |
4 |
4 |
Bundle analysis report Branch marc/migrate-to-new-proxy Project dashboard
hanspagel
added a commit
that referenced
this pull request
May 15, 2024
hanspagel
force-pushed
the
marc/migrate-to-new-proxy
branch
from
3247b84
to
a2f70e6
Compare
hanspagel
added a commit
that referenced
this pull request
May 16, 2024
hanspagel
added a commit
that referenced
this pull request
May 21, 2024
hanspagel
force-pushed
the
marc/migrate-to-new-proxy
branch
from
a2f70e6
to
a7583a3
Compare
geoffgscott
approved these changes
May 21, 2024
packages/api-client/src/components/ApiClient/Response/ResponseBody.vue
Outdated
Show resolved
Hide resolved
|
Preview deployed to https://4caacb26-041d-41a2-884d-fdc787a10f02--scalar-deploy-preview.netlify.app |
|
The code looks fine, but I tried using the preview and it says 201 but I got a CORS error? No idea whats going on lol |
amritk
approved these changes
May 21, 2024
tmastrom
approved these changes
May 21, 2024
|
The cors header has *, * as a value! I fixed this in the Go proxy, but proxy.scalar.com doesn’t have the fix yet. Because it’s in this PR here. 😂 |
…ated with a duplicate slash
hanspagel
force-pushed
the
marc/migrate-to-new-proxy
branch
from
336fa70
to
42b857a
Compare
This was referenced May 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates to the new proxy, which is now hosted on https://proxy.scalar.com
We used to have a custom proxy, which returned JSON always. The new proxy is a raw HTTP proxy (written in Go), which expects to get a
?scalar_url=query parameter, everything else (headers and such) aren’t touched at all and just proxied through.If you’re using the old proxy (https://api.scalar.com/request-proxy) we magically replace it with the new URL (https://proxy.scalar.com) on the fly. You’ll receive a deprecation warning, though. Please update your configuration to use the new proxy URL.
If you used to self-host our
@scalar/api-client-proxywe kindly ask you to switch to our new proxy (examples/proxy-server) written in Go. If you need help with that, reach out to us on Discord.Additional improvements
Additional fixes
Preview
(Comment hijacked by @hanspagel)