-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create scalar tailwind preset #1842
feat: create scalar tailwind preset #1842
Conversation
|
#1847 Bundle Size — 1.92MiB (~-0.01%).Warning Bundle contains 4 duplicate packages – View duplicate packages Bundle metrics
Bundle analysis report Branch brynn/doc-1864-align-and-merge-t... Project dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work @hwkr lets get this in so we can iterate and have an amazing foundation
7a870cd
to
1e299a8
Compare
Preview deployed to https://b95e8b01-65dd-4438-a4be-db0f8d24f070--scalar-deploy-preview.netlify.app |
This creates a Scalar Tailwind preset that defines all our core tailwind configuration. Different projects can extend the preset with more context specific configuration.
Originally the ideas was to export the core tailwind preset from
@scalar/themes
but I ran into issues with Storybook because importing anything from@scalar/themes
tries to import a CSS file which makes Storybook Vite angry.We probably shouldn't auto load
base.css
into the page just because someone imports a tailwind preset out of@scalar/themes
but I wasn't really sure how to fix that. I'm hoping @amritk might know of a good way to handle it. In the mean time I just split up the configurations / preset so it can be moved over easier as a next step.