Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create scalar tailwind preset #1842

Merged
merged 6 commits into from
May 31, 2024

Conversation

hwkr
Copy link
Contributor

@hwkr hwkr commented May 24, 2024

This creates a Scalar Tailwind preset that defines all our core tailwind configuration. Different projects can extend the preset with more context specific configuration.

Originally the ideas was to export the core tailwind preset from @scalar/themes but I ran into issues with Storybook because importing anything from @scalar/themes tries to import a CSS file which makes Storybook Vite angry.

We probably shouldn't auto load base.css into the page just because someone imports a tailwind preset out of @scalar/themes but I wasn't really sure how to fix that. I'm hoping @amritk might know of a good way to handle it. In the mean time I just split up the configurations / preset so it can be moved over easier as a next step.

@hwkr hwkr requested a review from amritk May 24, 2024 05:38
Copy link

changeset-bot bot commented May 24, 2024

⚠️ No Changeset found

Latest commit: 199edb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

relativeci bot commented May 27, 2024

#1847 Bundle Size — 1.92MiB (~-0.01%).

199edb8(current) vs f5c6bfd main#1846(baseline)

Warning

Bundle contains 4 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#1847
     Baseline
#1846
Improvement  Initial JS 1.92MiB(~-0.01%) 1.92MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 100% 0%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 1085 1085
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 157 157
No change  Duplicate Packages 4 4
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#1847
     Baseline
#1846
Improvement  JS 1.92MiB (~-0.01%) 1.92MiB

Bundle analysis reportBranch brynn/doc-1864-align-and-merge-t...Project dashboard

@hwkr hwkr marked this pull request as ready for review May 29, 2024 01:28
@hwkr hwkr requested a review from marclave as a code owner May 29, 2024 01:28
@hwkr hwkr requested review from antlio and geoffgscott May 29, 2024 19:45
Copy link
Contributor

@geoffgscott geoffgscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@marclave marclave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @hwkr lets get this in so we can iterate and have an amazing foundation

@hwkr hwkr force-pushed the brynn/doc-1864-align-and-merge-tailwind-configs branch from 7a870cd to 1e299a8 Compare May 31, 2024 20:31
Copy link
Contributor

@marclave marclave merged commit 0727585 into main May 31, 2024
10 checks passed
@marclave marclave deleted the brynn/doc-1864-align-and-merge-tailwind-configs branch May 31, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants