Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add null check for schema type on request #2233

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

marclave
Copy link
Member

the modal cant close cause we dont check the schema before the type! this fixes that : )

@marclave marclave requested a review from amritk June 25, 2024 00:54
Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: 720e338

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@amritk amritk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe

Copy link

relativeci bot commented Jun 25, 2024

#2457 Bundle Size — 2.01MiB (~+0.01%).

720e338(current) vs 4643bfa main#2454(baseline)

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#2457
     Baseline
#2454
Regression  Initial JS 2.01MiB(~+0.01%) 2.01MiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 100% 100%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 1236 1236
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 158 158
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2457
     Baseline
#2454
Regression  JS 2.01MiB (~+0.01%) 2.01MiB

Bundle analysis reportBranch marc/null-chuck-schema-type-requ...Project dashboard

@marclave marclave merged commit 48f0b1d into main Jun 25, 2024
8 checks passed
@marclave marclave deleted the marc/null-chuck-schema-type-request branch June 25, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants